[Mlir-commits] [mlir] [MLIR][Linalg] Lower vector.contract to chain of vector.fma for batch reduce matmul (PR #121885)

[Rolf Morel]

https://github.com/rolfmorel commented:

Per the below, I haven't gone through it all.

1.  As in the other PR, move all the files to Vector dialect dir.

2. Can we compose this transform out of existing transforms (with only slight amendments/modifications)? That is, would something like the following work? 
```
unroll vector.contract (e.g. using UnrollContractionPattern)
 |                             |
 |                             v
 |        hoist transfer and strided_slice ops (using replaceWithAdditionalYields maybe? Or hoist_loop_invariant_subsets)
 |                             |
 |                             v
 |        lower extracted_slices to vector.load
 v
lower vector.contract to vector.fma (e.g. `transform.apply_patterns.vector.lower_contraction lowering_strategy = parallelarith`)
```
With clean-up where necessary. Most of these are exposed as transform ops, though maybe not everything.

Let's have a chat offline about the above.

https://github.com/llvm/llvm-project/pull/121885