[Mlir-commits] [mlir] [MLIR] Enable import of non self referential alias scopes (PR #121987)
Tobias Gysi
llvmlistbot at llvm.org
Tue Jan 7 13:09:28 PST 2025
================
@@ -473,9 +487,17 @@ ModuleImport::processAliasScopeMetadata(const llvm::MDNode *node) {
StringAttr description = nullptr;
if (!aliasScope.getName().empty())
description = builder.getStringAttr(aliasScope.getName());
+ Attribute idattr;
+ if (verifySelfRef(scope))
+ idattr = DistinctAttr::create(builder.getUnitAttr());
+ else {
+ auto Name = cast<llvm::MDString>(scope->getOperand(0));
+ idattr = builder.getStringAttr(Name->getString());
+ }
----------------
gysit wrote:
```suggestion
Attribute idAttr;
if (verifySelfRef(scope)) {
idAttr = DistinctAttr::create(builder.getUnitAttr());
} else {
auto name = cast<llvm::MDString>(scope->getOperand(0));
idAttr = builder.getStringAttr(name->getString());
}
```
nit: same style nits as above
https://github.com/llvm/llvm-project/pull/121987
More information about the Mlir-commits
mailing list