[Mlir-commits] [mlir] Rewrites for I2 to I8 signed and unsigned extension (PR #121298)

Han-Chung Wang llvmlistbot at llvm.org
Mon Jan 6 23:46:23 PST 2025


================
@@ -1438,11 +1535,31 @@ struct RewriteAlignedSubByteIntExt : OpRewritePattern<ConversionOpType> {
     // Perform the rewrite.
     Value subByteExt;
     if (isSigned) {
----------------
hanhanW wrote:

nit: `conversionOp.getLoc()` is used several times. I think we can declare a variable, which makes code simpler. E.g., `Location loc = conversionOp.getLoc();`

https://github.com/llvm/llvm-project/pull/121298


More information about the Mlir-commits mailing list