[Mlir-commits] [mlir] [mlir][tosa] Add missing verifier for `tosa.pad` (PR #120934)

[Longsheng Mou]

CoTinker wrote:

> Hello @CoTinker , first of all THANK YOU - this is a pretty significant contribution and on a first review it looks fine. We only released the [TOSA 1.0 draft ](https://www.mlplatform.org/tosa/tosa_spec.html)recently (https://discourse.llvm.org/t/rfc-tosa-dialect-increment-to-v1-0/83708/1) so the work on updating the dialect to it is very welcome.
> 
> As mentioned earlier, the only hurdle here is aligning the LLVM and TensorFlow repositories - the latter picks up the former and contains lowerings to TOSA that would break CI unless coordinated effectively. @leandron and @jpienaar are currently engaged in ensuring this happens in a smooth manner, so wold you kindly wait until this is addressed before landing this change ?

Of course, I'll wait it until them address the inconsistent behaviour. Thanks for your review. And could you please let me know when all this work is done?

https://github.com/llvm/llvm-project/pull/120934