[Mlir-commits] [mlir] [mlir][presburger] Preserve relative ordering of symbols and non-symbol vars when setting up SymbolicLexSimplex (PR #119036)

[Christopher Bate]

christopherbate wrote:

 @Superty  I addressed all your comments and am passing existing tests. However, while testing in my downstream project, I'm seeing failures where I'm now hitting this unreachable (https://github.com/llvm/llvm-project/blob/main/mlir/lib/Analysis/Presburger/Simplex.cpp#L1463) in uses of Simplex unrelated to what motivated this bug originally.

This makes me think that perhaps this change, while still good cleanup of `computeReprWithOnlyDivLocals`, is just masking the underlying bug in Simplex/SimplexBase for the added test case.

I'll need to investigate more tomorrow.



https://github.com/llvm/llvm-project/pull/119036