[Mlir-commits] [mlir] [MLIR][Linalg] Transform pass to optimize and lower vector contract operation to FMA (PR #121748)

[Rolf Morel]

https://github.com/rolfmorel requested changes to this pull request.

Thanks for working on these patterns, @arun-thmn!

I left some comments here and there, though only on the hoisting transform for now.

My main points are as follows:
  
1. Split into two PRs, one for the hoisting transform and another for the FMA rewrite.
   * I suggest moving the FMA rewrite to its own PR.

3. Move files to `mlir/{include,lib}/mlir/Dialect/Vector`.

4. Try to generalize the hoisting transform?
   * that is, are the outer m- and n- loops really necessary for valid hoisting?
   * if we can generalize, might be worthwhile to expose the hoisting as a C++ Vector utility function as well.

https://github.com/llvm/llvm-project/pull/121748