[Mlir-commits] [mlir] [mlir][vector]advance support extract insert under dynamic case. (PR #121631)

Oleksandr Alex Zinenko llvmlistbot at llvm.org
Mon Jan 6 06:56:48 PST 2025


================
@@ -1096,6 +1096,26 @@ class VectorExtractOpConversion
     SmallVector<OpFoldResult> positionVec = getMixedValues(
         adaptor.getStaticPosition(), adaptor.getDynamicPosition(), rewriter);
 
+    for (unsigned idx = 0; idx < positionVec.size(); ++idx) {
+      if (auto position = llvm::dyn_cast<Value>(positionVec[idx])) {
+        auto defOp = position.getDefiningOp();
----------------
ftynse wrote:

https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable

MLIR systematically expands `auto` unless the type is obvious from the statement-level context.

https://github.com/llvm/llvm-project/pull/121631


More information about the Mlir-commits mailing list