[Mlir-commits] [mlir] [mlir][vector]advance support extract insert under dynamic case. (PR #121631)

[Oleksandr Alex Zinenko]

================
@@ -1231,6 +1251,25 @@ class VectorInsertOpConversion
 
     SmallVector<OpFoldResult> positionVec = getMixedValues(
         adaptor.getStaticPosition(), adaptor.getDynamicPosition(), rewriter);
+    for (unsigned idx = 0; idx < positionVec.size(); ++idx) {
----------------
ftynse wrote:

It is a bad practice to copy large chunks of code. Use a function instead.

https://github.com/llvm/llvm-project/pull/121631