[Mlir-commits] [mlir] [mlir][tosa] Add acc_type to Tosa-v1.0 Conv Ops (PR #121466)

Luke Hutton llvmlistbot at llvm.org
Mon Jan 6 06:00:42 PST 2025


https://github.com/lhutton1 commented:

Apologies I hadn't noticed `AvgPool2D`, happy to pull out moving the `acc_type` checks from the verifier to the validation pass into a separate change, especially since  it doesn't impose any new restrictions (from v0.80 expectations).

LGTM with an additional comment to consider and a small nit - does it need some negative tests to check the verifier?

https://github.com/llvm/llvm-project/pull/121466


More information about the Mlir-commits mailing list