[Mlir-commits] [mlir] [mlir][tosa] Add acc_type to Tosa-v1.0 Conv Ops (PR #121466)

[Georgios Pinitas]

https://github.com/GeorgeARM commented:

Looking at the existing code and this patch I see a discrepancy of how the verifiers and validations have been laid out. I know that I made the suggestion to move the check into the `TosaValidationPass` but this is not how `AvgPool2d` is being done at the moment.
So, could you please move the checks back to the verifier and decide what things need to move into the validation pass all-together with subsequent patches?

https://github.com/llvm/llvm-project/pull/121466