[Mlir-commits] [mlir] [mlir] DCE `friend Dialect::registerDialect` (PR #121728)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-core

Author: Maksim Levental (makslevental)

<details>
<summary>Changes</summary>

There's no implementation for this decl. Should've been removed here 

https://github.com/llvm/llvm-project/commit/b72e13c242d9bbe1a4c7e471da98718bde85fa78#diff-fad55ed6dd6c9cae07409d354d6cfdef35cef1550b568d6b57d946590b14a6cdL256

I guess.

---
Full diff: https://github.com/llvm/llvm-project/pull/121728.diff


1 Files Affected:

- (modified) mlir/include/mlir/IR/Dialect.h (-1) 


``````````diff
diff --git a/mlir/include/mlir/IR/Dialect.h b/mlir/include/mlir/IR/Dialect.h
index f3e5f6d88c5317..fb24a6895dabdc 100644
--- a/mlir/include/mlir/IR/Dialect.h
+++ b/mlir/include/mlir/IR/Dialect.h
@@ -368,7 +368,6 @@ class Dialect {
   DenseSet<std::pair<TypeID, TypeID>> unresolvedPromisedInterfaces;
 
   friend class DialectRegistry;
-  friend void registerDialect();
   friend class MLIRContext;
 };
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/121728