[Mlir-commits] [mlir] Rewrites for I2 to I8 signed and unsigned extension (PR #121298)

[Andrzej Warzyński]

================
@@ -1489,6 +1610,10 @@ struct RewriteAlignedSubByteIntTrunc : OpRewritePattern<arith::TruncIOp> {
                                              truncOp)))
       return failure();
 
+    // not supported currently.
----------------
banach-space wrote:

[nit] I'd move this near `commonConversionPrecondition` - this check is basically "complementing" that hook.
```suggestion
    // TODO: Add support for truncating to i2.
```

Also, I'd add a negative test.

https://github.com/llvm/llvm-project/pull/121298