[Mlir-commits] [mlir] [mlir][python] declare `_PyClassMethod_New` undefined at link time (PR #121597)

Maksim Levental llvmlistbot at llvm.org
Fri Jan 3 12:05:25 PST 2025


================
@@ -686,6 +686,12 @@ function(add_mlir_python_extension libname extname)
   endif()
 
   target_compile_options(${libname} PRIVATE ${eh_rtti_enable})
+  if(APPLE)
+    # NanobindAdaptors.h uses PyClassMethod_New to build `pure_subclass`es but nanobind
+    # doesn't declare this API as undefined in its linker flags. so we need to declare it as such
----------------
makslevental wrote:

```suggestion
    # doesn't declare this API as undefined in its linker flags. So we need to declare it as such
```

https://github.com/llvm/llvm-project/pull/121597


More information about the Mlir-commits mailing list