[Mlir-commits] [mlir] [mlir][Transforms] Fix build after #116524 (PR #121578)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Fri Jan 3 07:26:04 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir-core
Author: Matthias Springer (matthias-springer)
<details>
<summary>Changes</summary>
Fix build errors after #<!-- -->116524.
```
error: call of overloaded ‘TypeRange(ValueVector&)’ is ambiguous
```
---
Full diff: https://github.com/llvm/llvm-project/pull/121578.diff
1 Files Affected:
- (modified) mlir/lib/Transforms/Utils/DialectConversion.cpp (+3-4)
``````````diff
diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
index 0c5520988eff38..6c3863e4c7f666 100644
--- a/mlir/lib/Transforms/Utils/DialectConversion.cpp
+++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -227,7 +227,7 @@ ConversionValueMapping::lookupOrDefault(Value from,
ValueVector current{from};
do {
// Store the current value if the types match.
- if (TypeRange(current) == desiredTypes)
+ if (TypeRange(ValueRange(current)) == desiredTypes)
desiredValue = current;
// If possible, Replace each value with (one or multiple) mapped values.
@@ -271,9 +271,8 @@ ConversionValueMapping::lookupOrDefault(Value from,
ValueVector ConversionValueMapping::lookupOrNull(Value from,
TypeRange desiredTypes) const {
ValueVector result = lookupOrDefault(from, desiredTypes);
- TypeRange resultTypes(result);
if (result == ValueVector{from} ||
- (!desiredTypes.empty() && resultTypes != desiredTypes))
+ (!desiredTypes.empty() && TypeRange(ValueRange(result)) != desiredTypes))
return {};
return result;
}
@@ -1291,7 +1290,7 @@ LogicalResult ConversionPatternRewriterImpl::remapValues(
}
ValueVector repl = mapping.lookupOrDefault(operand, legalTypes);
- if (!repl.empty() && TypeRange(repl) == legalTypes) {
+ if (!repl.empty() && TypeRange(ValueRange(repl)) == legalTypes) {
// Mapped values have the correct type or there is an existing
// materialization. Or the operand is not mapped at all and has the
// correct type.
``````````
</details>
https://github.com/llvm/llvm-project/pull/121578
More information about the Mlir-commits
mailing list