[Mlir-commits] [mlir] [mlir][tosa] Add missing verifier for `tosa.pad` (PR #120934)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 7b23f413d1f76532825e470b523e971818d453ca 7e67d67713b6ee74c09c2be9b5b57d7ad7cc98ea --extensions cpp -- mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp mlir/lib/Dialect/Tosa/IR/TosaOps.cpp mlir/lib/Dialect/Tosa/Transforms/TosaDecomposeConv2D.cpp mlir/lib/Dialect/Tosa/Transforms/TosaDecomposeDepthwise.cpp mlir/lib/Dialect/Tosa/Transforms/TosaDecomposeTransposeConv.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp b/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp
index dd180f4b1f..b5a0da15e7 100644
--- a/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp
+++ b/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp
@@ -345,10 +345,8 @@ public:
     highValues.reserve(rank);
 
     for (int i = 0; i < rank; i++) {
-      Value lowIndex =
-          rewriter.create<arith::ConstantIndexOp>(loc, 2 * i);
-      Value highIndex =
-          rewriter.create<arith::ConstantIndexOp>(loc, 2 * i + 1);
+      Value lowIndex = rewriter.create<arith::ConstantIndexOp>(loc, 2 * i);
+      Value highIndex = rewriter.create<arith::ConstantIndexOp>(loc, 2 * i + 1);
       Value lowVal = rewriter.createOrFold<tensor::ExtractOp>(
           loc, padding, ValueRange({lowIndex}));
       Value highVal = rewriter.createOrFold<tensor::ExtractOp>(
diff --git a/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp b/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp
index d5a37eef76..1835886d2d 100644
--- a/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp
+++ b/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp
@@ -831,7 +831,8 @@ LogicalResult tosa::PadOp::verify() {
   if (!paddingType.isDynamicDim(0) &&
       paddingType.getDimSize(0) != inputType.getRank() * 2)
     return emitOpError() << "expected padding tensor dim 0 to have size "
-                         << inputType.getRank() << " (2*rank(input)) but got size "
+                         << inputType.getRank()
+                         << " (2*rank(input)) but got size "
                          << paddingType.getDimSize(0);
 
   return success();

``````````

</details>


https://github.com/llvm/llvm-project/pull/120934