[Mlir-commits] [mlir] [mlir][spirv] Do SPIR-V serialization in -test-vulkan-runner-pipeline (PR #121494)

[Andrea Faulds]

================
@@ -135,21 +132,33 @@ LogicalResult ConvertGpuLaunchFuncToVulkanLaunchFunc::declareVulkanLaunchFunc(
   return success();
 }
 
-LogicalResult ConvertGpuLaunchFuncToVulkanLaunchFunc::createBinaryShader(
-    ModuleOp module, std::vector<char> &binaryShader) {
+LogicalResult ConvertGpuLaunchFuncToVulkanLaunchFunc::getBinaryShader(
+    ModuleOp module, StringAttr &binaryAttr) {
----------------
andfau-amd wrote:

Oh, yeah, thanks for reminding me that exists! Optionals are kind of ugly to work with in C++ but it's still an improvement.

https://github.com/llvm/llvm-project/pull/121494