[Mlir-commits] [mlir] [mlir python][cmake] Fixed nanobind target used in target_compile_options in AddMLIRPython.cmake (PR #121477)

Maksim Levental llvmlistbot at llvm.org
Thu Jan 2 13:06:55 PST 2025


https://github.com/makslevental approved this pull request.

I'm approving to unblock (because the impl is ~correct) but I think we should have a quick discussion about steps going forward because I think this is really brittle. I guess the correct thing to do here is either 

1. remove those compile options
2. fix them upstream in nanobind itself

cc @jpienaar @hawkinsp @stellaraccident 

https://github.com/llvm/llvm-project/pull/121477


More information about the Mlir-commits mailing list