[Mlir-commits] [mlir] [MLIR] Prevent invalid IR from being passed outside of RemoveDeadValues (PR #121079)

Andrzej Warzyński llvmlistbot at llvm.org
Thu Jan 2 11:26:42 PST 2025


================
@@ -617,23 +736,34 @@ void RemoveDeadValues::runOnOperation() {
   auto &la = getAnalysis<RunLivenessAnalysis>();
   Operation *module = getOperation();
 
+  // Tracks values eligible for erasure - complements liveness analysis to
+  // identify "droppable" values.
+  DenseSet<Value> deadVals;
+
+  // Maintains a list of Ops, values, branches, etc., slated for cleanup at the
+  // end of this pass.
+  RDVFinalCleanupList finalRDVFinalCleanupList;
----------------
banach-space wrote:

[nit] "final" used twice in this variable name 😅 

https://github.com/llvm/llvm-project/pull/121079


More information about the Mlir-commits mailing list