[Mlir-commits] [mlir] 4485d91 - [mlir][linalg] Add vectorization to the e2e test for tensor.unpack (#123032)

[llvmlistbot at llvm.org]

Author: Andrzej Warzyński
Date: 2025-02-28T20:34:54Z
New Revision: 4485d91786e9f624cdb4c7579d0938809291e0f9

URL: https://github.com/llvm/llvm-project/commit/4485d91786e9f624cdb4c7579d0938809291e0f9
DIFF: https://github.com/llvm/llvm-project/commit/4485d91786e9f624cdb4c7579d0938809291e0f9.diff

LOG: [mlir][linalg] Add vectorization to the e2e test for tensor.unpack (#123032)

Following on from #122927 + #123031 that added support for masked
vectorization of `tensor.insert_slice`, this PR extends the e2e test for
`tensor.unpack` to leverage the new functionality.

Added: 
    

Modified: 
    mlir/test/Integration/Dialect/Linalg/CPU/pack-dynamic-inner-tile.mlir
    mlir/test/Integration/Dialect/Linalg/CPU/unpack-dynamic-inner-tile.mlir

Removed: 
    


################################################################################
diff  --git a/mlir/test/Integration/Dialect/Linalg/CPU/pack-dynamic-inner-tile.mlir b/mlir/test/Integration/Dialect/Linalg/CPU/pack-dynamic-inner-tile.mlir
index a8daa0b855d00..7b410ccee9633 100644
--- a/mlir/test/Integration/Dialect/Linalg/CPU/pack-dynamic-inner-tile.mlir
+++ b/mlir/test/Integration/Dialect/Linalg/CPU/pack-dynamic-inner-tile.mlir
@@ -121,11 +121,11 @@ module @transforms attributes { transform.with_named_sequence } {
       transform.apply_patterns.canonicalization
     } : !transform.op<"func.func">
 
-    // 3. Bufferize before lowering to LLVM
+    // 4. Bufferize before lowering to LLVM
     %bufferize = transform.bufferization.one_shot_bufferize %module
       {bufferize_function_boundaries=true} : (!transform.any_op) -> !transform.any_op
 
-    // 4. Canonicalize
+    // 5. Canonicalize
     %func_op_bufferized = transform.structured.match ops{["func.func"]} in %bufferize : (!transform.any_op) -> !transform.op<"func.func">
     transform.apply_patterns to %func_op_bufferized {
       transform.apply_patterns.canonicalization

diff  --git a/mlir/test/Integration/Dialect/Linalg/CPU/unpack-dynamic-inner-tile.mlir b/mlir/test/Integration/Dialect/Linalg/CPU/unpack-dynamic-inner-tile.mlir
index c5360ee1ec954..b62ca21e236ff 100644
--- a/mlir/test/Integration/Dialect/Linalg/CPU/unpack-dynamic-inner-tile.mlir
+++ b/mlir/test/Integration/Dialect/Linalg/CPU/unpack-dynamic-inner-tile.mlir
@@ -1,5 +1,6 @@
 // DEFINE: %{compile} =  mlir-opt %s \
-// DEFINE:  -transform-interpreter -test-transform-dialect-erase-schedule |\
+// DEFINE:  -transform-interpreter -test-transform-dialect-erase-schedule \
+// DEFINE:  --lower-vector-mask |\
 // DEFINE: mlir-opt \
 // DEFINE:  -test-lower-to-llvm -o %t
 // DEFINE: %{entry_point} = main
@@ -90,14 +91,19 @@ module @transforms attributes { transform.with_named_sequence } {
     %func_op = transform.get_parent_op %tiled_pack_op_p {isolated_from_above} : (!transform.any_op) -> !transform.op<"func.func">
     transform.apply_patterns to %func_op {
       transform.apply_patterns.linalg.decompose_pack_unpack
-      transform.apply_patterns.linalg.decompose_pad
+      transform.apply_patterns.canonicalization
     } : !transform.op<"func.func">
 
-    // 3. Bufferize before lowering to LLVM
+    // 3. Vectorize tensor.insert_slice
+    // Vector sizes match the inner tiles in the payload IR.
+    %slice = transform.structured.match ops{["tensor.insert_slice"]} in %func_op : (!transform.op<"func.func">) -> !transform.any_op
+    transform.structured.vectorize %slice vector_sizes [8, 1] : !transform.any_op
+
+    // 4. Bufferize before lowering to LLVM
     %bufferize = transform.bufferization.one_shot_bufferize %module
       {bufferize_function_boundaries=true} : (!transform.any_op) -> !transform.any_op
 
-   // 4. Canonicalize
+    // 5. Canonicalize
     %func_op_bufferized = transform.structured.match ops{["func.func"]} in %bufferize : (!transform.any_op) -> !transform.op<"func.func">
     transform.apply_patterns to %func_op_bufferized {
       transform.apply_patterns.canonicalization