[Mlir-commits] [mlir] Reapply [MLIR][LLVMIR] Import unregistered intrinsics via llvm.intrin… (PR #129174)

[Tobias Gysi]

================
@@ -1642,6 +1642,46 @@ FlatSymbolRefAttr ModuleImport::convertCalleeName(llvm::CallBase *callInst) {
   return {};
 }
 
+LogicalResult mlir::LLVMImportInterface::convertUnregisteredIntrinsic(
----------------
gysit wrote:

> Note you cannot access any moduleImport state in mlir/include/mlir/Target/LLVMIR/LLVMImportInterface.h because it's a fwd declaration.

Ah ok that makes sense. We could rearrange things and call it from there but let's not do that now.

Having it in the interface seems more consistent but there was a linking issue? Alternative could also be to go back to the implementation method which is just a static function as it was in your original PR. That is also ok!

https://github.com/llvm/llvm-project/pull/129174