[Mlir-commits] [mlir] [MLIR] Add pattern to bubble up tensor.extract_slice (PR #126898)
ofri frishman
llvmlistbot at llvm.org
Fri Feb 28 01:23:23 PST 2025
ofri-frishman wrote:
Regarding the negative test for `BubbleUpExpandShapeThroughExtractSlice` within the tests for `transform.structured.fuse` - I understand your point, but I see this a bit differently.
I think that having such negative tests in `transform.structured.fuse` help clarify what you could expect to work and not work for `transform.structured.fuse`. It isn't meant to get negative test coverage for the `BubbleUpExpandShapeThroughExtractSlice` as that is already achieved in the specific tests written directly for `BubbleUpExpandShapeThroughExtractSlice`.
https://github.com/llvm/llvm-project/pull/126898
More information about the Mlir-commits
mailing list