[Mlir-commits] [mlir] [mlir[tosa] Switch zero point of avgpool2d to input variable type (PR #128983)

Jack Frankland llvmlistbot at llvm.org
Thu Feb 27 06:42:14 PST 2025


================
@@ -804,6 +804,15 @@ class AvgPool2dConverter : public OpRewritePattern<tosa::AvgPool2dOp> {
       return failure();
     SmallVector<Value> dynamicDims = *dynamicDimsOr;
 
+    int64_t inputZpVal;
+    int64_t outputZpVal;
+    if (op.getInputZeroPoint(inputZpVal).failed() ||
----------------
FranklandJack wrote:

Should we consider splitting these errors into two separate `if` statements? That way we could add detail in the error message as to whether it was the input zero point or the output zero point that was missing.

https://github.com/llvm/llvm-project/pull/128983


More information about the Mlir-commits mailing list