[Mlir-commits] [mlir] [MLIR][AMDGPU] Add OCP FP8 support for new hardware (PR #127728)

Mirza Halilčević llvmlistbot at llvm.org
Thu Feb 27 03:32:39 PST 2025


================
@@ -696,7 +696,8 @@ LogicalResult TosaValidation::applyErrorIfCheck(Operation *op) {
 
 bool TosaValidation::isValidElementType(Type type) {
   if (isa<FloatType>(type)) {
-    return type.isF32() || type.isF16() || type.isBF16();
+    return isa<Float32Type, Float16Type, BFloat16Type, Float8E4M3FNType,
+               Float8E5M2Type>(type);
----------------
mirza-halilcevic wrote:

Seems like the TOSA spec doesn't support them https://github.com/llvm/llvm-project/pull/106160#discussion_r1851126754
This was addressed in https://github.com/llvm/llvm-project/pull/127728/commits/5bace4697b6f381f7cef0b6a25fecc67268565ff


https://github.com/llvm/llvm-project/pull/127728


More information about the Mlir-commits mailing list