[Mlir-commits] [mlir] [mlir] Refactor ConvertVectorToLLVMPass options (PR #128219)

[Andrzej Warzyński]

================
@@ -0,0 +1,21 @@
+// Simple regression test that ensures ConvertVectorToLLVMPass options remain
+// serialisable. We don't need to actually parse any IR to print the pass
+// options. We just need to provide --dump-pass-pipeline
----------------
banach-space wrote:

It would be good to add a bit more documentation to capture some bits from our lengthy discussion. See my suggestion below.

[nit] Note, pretty much every test is a regression test :) I would just drop that. Others might disagree.

```suggestion
// Ensure that ConvertVectorToLLVMPass options remain serialisable. 

// This test also allows us to exercise these options (to some extent) even if we don't use them in tests. This is quite relevant for the `Vector` Dialect (and `--convert-vector-to-llvm` pass) as in many cases we use TD (Transform Dialect) rather than `--convert-vector-to-llvm` for testing.

// We don't need to actually parse any IR to print the pass
// options. We just need to provide --dump-pass-pipeline
```

https://github.com/llvm/llvm-project/pull/128219