[Mlir-commits] [mlir] [mlir][linalg] Add Linalg::generateScalarImplementation (PR #128816)

[llvmlistbot at llvm.org]

MaheshRavishankar wrote:

> I don't quite follow the context here and the bigger picture.
> 
> > Add generateScalarImplementation so that linalg.pack/unpack ops on memrefs can be lowered to scalar codes.
> 
> With no documentation and tests, `generateScalarImplementation` feels like some arbitrary ad-hoc hook.

It is the implementation of the method in `TilingInterface` (https://github.com/llvm/llvm-project/blob/f6703a4ff56972ed6bd1693cdb51cc3bd5848582/mlir/include/mlir/Interfaces/TilingInterface.td#L341). 

> 
> If this some initial step to make `linalg.pack` and `linalg.unpack` support MemRef, then could we start with a higher-level GitHub issue (or Discourse thread) outlining the high level steps?
> 
> Thanks!

If the op is moved to `linalg` I think it should be made to support memref also now. There is no reason not to.

https://github.com/llvm/llvm-project/pull/128816