[Mlir-commits] [mlir] [mlir][TosaToLinalg] Fix TosaToLinalg to restrict `tosa.cast` types to integer or float (PR #128859)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Wed Feb 26 10:20:16 PST 2025


Jerry-Ge wrote:

> This relates to the TOSA legalizations and casting of types like MLIR quantized ones that linalg will probably fail/misbehave. So the patch looks fine from what I gather? Unless I am missing something @Jerry-Ge

Quote from @sjarus 's comment here: https://discourse.llvm.org/t/tosa-cast-valid-supported-data-types/84808

> Invoking this pass between TOSA generation and downstream compilation should capture cases where spec compliance requires changes to the legalization. Broadly disabling any spec non-compliant legalizations might not be a good approach, since it blocks experimental activity.

https://github.com/llvm/llvm-project/pull/128859


More information about the Mlir-commits mailing list