[Mlir-commits] [mlir] [MLIR][LLVMIR] Import unregistered intrinsics via llvm.intrinsic_call (PR #128626)

[Tobias Gysi]

================
@@ -98,6 +98,12 @@ class LLVMImportDialectInterface
 /// efficient dispatch.
 class LLVMImportInterface
     : public DialectInterfaceCollection<LLVMImportDialectInterface> {
+private:
+  // Generate llvm.call_intrinsic when no supporting dialect available.
+  LogicalResult
+  convertUnregisteredIntrinsic(OpBuilder &builder, llvm::CallInst *inst,
----------------
gysit wrote:

Can you move the function at the end of the class declaration in the private section with the member variables. Additionally it may make sense to make it a static function since it doesn't seem to access any members.

https://github.com/llvm/llvm-project/pull/128626