[Mlir-commits] [mlir] [MLIR] VectorToLLVM: Fix vector.insert conversion for 0-D vectors, and add a test (PR #128810)

[Kunwar Grover]

Groverkss wrote:

I did a similar bugfix for vector.extract recently: https://github.com/llvm/llvm-project/pull/117731 . One thing I did in that PR, which would be nice to do for vector.insert also is revisiting the logic for the lowering again. It has gone through three iterations: static indices only, dynamic indices and now this PR.

You don't have to do it if you just want to land this fix, but if you are interested in improving the logic, it would be good to do it in this PR.

https://github.com/llvm/llvm-project/pull/128810