[Mlir-commits] [mlir] [MLIR][LLVMIR] Import unregistered intrinsics via llvm.intrinsic_call (PR #128626)

[Bruno Cardoso Lopes]

================
@@ -155,7 +165,19 @@ class LLVMImportInterface
   LogicalResult convertIntrinsic(OpBuilder &builder, llvm::CallInst *inst,
                                  LLVM::ModuleImport &moduleImport) const {
     // Lookup the dialect interface for the given intrinsic.
-    Dialect *dialect = intrinsicToDialect.lookup(inst->getIntrinsicID());
+    llvm::Intrinsic::ID intrinId = inst->getIntrinsicID();
----------------
bcardosolopes wrote:

> I wonder if we can ever get not_intrinsic?

I'm trying to defend against `llvm::CallInst *inst`, but the call site for `convertIntrinsic` current covers this with `dyn_cast<llvm::IntrinsicInst>(inst)` - I'll turn this into an assert instead. 


https://github.com/llvm/llvm-project/pull/128626