[Mlir-commits] [mlir] [MLIR][LLVMIR] Import unregistered intrinsics via llvm.intrinsic_call (PR #128626)

[Tobias Gysi]

================
@@ -155,7 +165,19 @@ class LLVMImportInterface
   LogicalResult convertIntrinsic(OpBuilder &builder, llvm::CallInst *inst,
                                  LLVM::ModuleImport &moduleImport) const {
     // Lookup the dialect interface for the given intrinsic.
-    Dialect *dialect = intrinsicToDialect.lookup(inst->getIntrinsicID());
+    llvm::Intrinsic::ID intrinId = inst->getIntrinsicID();
----------------
gysit wrote:

```suggestion
    // Verify the intrinsic identifier maps to an actual intrinsic.
    llvm::Intrinsic::ID intrinId = inst->getIntrinsicID();
```
nit: The comment above should probably move downs the the lookup?

I wonder if we can ever get not_intrinsic?

https://github.com/llvm/llvm-project/pull/128626