[Mlir-commits] [mlir] [mlir][vector] Add a check to ensure input vector rank equals target shape rank (PR #127706)

Andrzej Warzyński llvmlistbot at llvm.org
Tue Feb 25 09:51:19 PST 2025


================
@@ -768,6 +768,15 @@ func.func @extract_strided_slice(%arg0: vector<4x8x16xf32>) {
 
 // -----
 
+func.func @extract_strided_slice(%arg0: vector<3x2x2xf32>) {
+  // expected-error at +1 {{expected input vector rank to match target shape rank}}
----------------
banach-space wrote:

OK, so you've made this error up:
```
// expected-error at +1 {{expected input vector rank to match target shape rank}}
```
? :) As in, it wasn't an actual error that you saw? That's what I was going by when reviewing 😅 

> And i guess this test is not required since it's been taken care of.

Indeed

https://github.com/llvm/llvm-project/pull/127706


More information about the Mlir-commits mailing list