[Mlir-commits] [mlir] [mlir][DataLayout] Add a default memory space entry to the data layout. (PR #127416)

[Rolf Morel]

================
@@ -318,7 +318,8 @@ combineOneSpec(DataLayoutSpecInterface spec,
            "unexpected data layout entry for built-in type");
 
     auto interface = cast<DataLayoutTypeInterface>(typeSample);
-    if (!interface.areCompatible(entriesForType.lookup(kvp.first), kvp.second))
+    if (!interface.areCompatible(entriesForType.lookup(kvp.first), kvp.second,
----------------
rolfmorel wrote:

I see, though am not able to say if DL checks for types should really have access to the whole spec.

Also is `spec` here the right spec to pass? The specs are in the process of being combined at this point, right? `spec` is just the latest to be added, I think (it's a while since I looked at that code). 

@Dinistro, do you happen to have any comments on this approach and the proposed resolution?

https://github.com/llvm/llvm-project/pull/127416