[Mlir-commits] [mlir] [mlir][Vector] Move vector.extract canonicalizers for DenseElementsAttr to folders (PR #127995)

[Andrzej Warzyński]

https://github.com/banach-space commented:

The code changes LGTM, thanks!

That said, I don’t quite follow this from the summary:

> Folders are local, and it's always better to implement a folder than a canonicalizer.

Why? This is a rather strong statement, and I don’t see any clear indication of this in our documentation: [MLIR Canonicalization Docs](https://mlir.llvm.org/docs/Canonicalization/)

I have no objections to landing this, but let’s ensure we have a valid reason for this preference. Otherwise, it feels somewhat arbitrary.

https://github.com/llvm/llvm-project/pull/127995