[Mlir-commits] [mlir] [MLIR][AMDGPU] Add OCP FP8 support for new hardware (PR #127728)
Mirza Halilčević
llvmlistbot at llvm.org
Mon Feb 24 14:19:02 PST 2025
mirza-halilcevic wrote:
> A few changes, hopefully not contradicting previous reviews.
>
> Also, if you look in your downstream, there's a fix to `wmmaPushInputOperand` and probably the `amdgpu.wmma` op generally - can you see if those were a separate PR?
@krzysz00 Are you referring to [this](https://github.com/ROCm/rocMLIR/blob/b34604275d8ebfc9a830be931f3909f9cdd00ac2/external/llvm-project/mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp#L393)? Looks like this was supposed to be a part of #106388, but maybe got unintentionally left out.
https://github.com/llvm/llvm-project/pull/127728
More information about the Mlir-commits
mailing list