[Mlir-commits] [mlir] [mlir] Refactor ConvertVectorToLLVMPass options (PR #128219)
Andrzej Warzyński
llvmlistbot at llvm.org
Mon Feb 24 11:02:38 PST 2025
https://github.com/banach-space commented:
Thank you for working on this 🙏🏻
Before we proceed, I raised a question about the overall direction in MLIR regarding these flags. I don't mean to block this - if this functionality is required, lets land it. However, if we are to land it, we should also properly test/exercise these flags. That's one thing that was missing in the [previous PR](https://github.com/llvm/llvm-project/pull/123491).
Regardless of the outcome, this is helping us improve MLIR 🙏🏻
https://github.com/llvm/llvm-project/pull/128219
More information about the Mlir-commits
mailing list