[Mlir-commits] [mlir] [mlir][xegpu] Improve XeGPU op verification logic for SIMT flavor and update tests. (PR #127920)

Artem Kroviakov llvmlistbot at llvm.org
Mon Feb 24 10:47:10 PST 2025


================
@@ -239,6 +244,7 @@ LogicalResult TensorDescType::verify(
     llvm::ArrayRef<int64_t> shape, mlir::Type elementType,
     mlir::Attribute encoding, mlir::Attribute sg_map) {
   size_t rank = shape.size();
+  unsigned packingFactor = 32 / elementType.getIntOrFloatBitWidth();
----------------
akroviakov wrote:

It may be worth to make `32` a named variable just to clarify its meaning right away, this could also spare a comment below.

> This is because each work item access data in 32 bit granularity

https://github.com/llvm/llvm-project/pull/127920


More information about the Mlir-commits mailing list