[Mlir-commits] [mlir] [mlir][tosa] Fix ability to expand ranks with dynamic shape support (PR #128037)

Georgios Pinitas llvmlistbot at llvm.org
Mon Feb 24 09:59:12 PST 2025


================
@@ -88,9 +88,9 @@ computeReshapeOutput(ArrayRef<int64_t> higherRankShape,
     higherRankDim = higherRankShape[i];
     lowerRankDim = lowerRankShape[j];
 
-    if (lowerRankDim == 1 && higherRankDim > 1)
+    if (lowerRankDim == 1 && higherRankDim != 1)
----------------
GeorgeARM wrote:

Seems that this whole function can be simplified by right aligning the lower and high rank shapes unless I am missing something?

https://github.com/llvm/llvm-project/pull/128037


More information about the Mlir-commits mailing list