[Mlir-commits] [mlir] [MLIR][OpenMP] Simplify definition of the BlockArgOpenMPOpInterface, NFC (PR #128198)

Tom Eccles llvmlistbot at llvm.org
Mon Feb 24 08:21:49 PST 2025


https://github.com/tblah approved this pull request.

LGTM.

I am worried that this is getting gradually harder and harder for anyone new to read the code and understand what is going on (for example somebody who only knows the basics of tablegen would have to think quite hard to know even what methods are defined), but considered on its own this patch is a clear maintainability improvement and the documentation @kparzysz suggested helps a lot.

https://github.com/llvm/llvm-project/pull/128198


More information about the Mlir-commits mailing list