[Mlir-commits] [mlir] [mlir][OpenMP] initialize (first)private variables before task exec (PR #125304)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff db40592de60f579afa18db3a06a4505c8e63de65 f8b1812d03f04cd8efa2a02202849e08320fa524 --extensions cpp -- mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp b/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
index 8e071cd96a..f3e57e8fca 100644
--- a/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
@@ -1339,8 +1339,7 @@ findAssociatedValue(Value privateVar, llvm::IRBuilderBase &builder,
 static llvm::Error initPrivateVar(
     llvm::IRBuilderBase &builder, LLVM::ModuleTranslation &moduleTranslation,
     omp::PrivateClauseOp &privDecl, Value mlirPrivVar, BlockArgument &blockArg,
-    llvm::Value **llvmPrivateVarIt,
-    llvm::BasicBlock *privInitBlock,
+    llvm::Value **llvmPrivateVarIt, llvm::BasicBlock *privInitBlock,
     llvm::DenseMap<Value, Value> *mappedPrivateVars = nullptr) {
   Region &initRegion = privDecl.getInitRegion();
   if (initRegion.empty()) {
@@ -1827,9 +1826,8 @@ convertOmpTaskOp(omp::TaskOp taskOp, llvm::IRBuilderBase &builder,
         llvmAllocType, /*ArraySize=*/nullptr, "omp.private.alloc");
 
     builder.SetInsertPoint(initBlock->getTerminator());
-    auto err =
-        initPrivateVar(builder, moduleTranslation, privDecl, mlirPrivVar,
-                       blockArg, &llvmPrivateVar, initBlock);
+    auto err = initPrivateVar(builder, moduleTranslation, privDecl, mlirPrivVar,
+                              blockArg, &llvmPrivateVar, initBlock);
     if (err)
       return handleError(std::move(err), *taskOp.getOperation());
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/125304