[Mlir-commits] [mlir] [mlir][EmitC] Add pass that combines all available emitc conversions (PR #117549)

[Simon Camphausen]

simon-camp wrote:

> @simon-camp it seems like there are some issues with this patch, based on the test failures. I'm afraid I'm not familiar enough here to offer much advice, but it seems like some of the tests, like `func.mlir` expect some additional transform to happen to the function.
> 
> ```
> mlir-opt -convert-to-emitc mlir/test/Conversion/ConvertToEmitC/func.mlir 
> |`FileCheck mlir/test/Conversion/ConvertToEmitC/func.mlir mlir/test/Conversion/ConvertToEmitC/func.mlir:18:5: error: 'emitc.return' op expects parent op 'emitc.func'
>     return
>     ^
> mlir/test/Conversion/ConvertToEmitC/func.mlir:18:5: note: see current operation: "emitc.return"() : () -> ()
> FileCheck error: '<stdin>' is empty.
> FileCheck command line:  FileCheck mlir/test/Conversion/ConvertToEmitC/func.mlir
> ```
> 

This seems to be a layering issue. The memref->emitc type conversion is only available when the memref dialect is loaded. And that dialect is not loaded for the test. Nonetheless there are more failing tests I need to fix.

https://github.com/llvm/llvm-project/pull/117549