[Mlir-commits] [mlir] [mlir][affine][gpu] support unroll dynamic value and apply it to gpu.thread_id op (PR #128113)

[Krzysztof Drewniak]

https://github.com/krzysz00 requested changes to this pull request.

I have concerns about this.

I'm a bit dubious about how this special-case for fetching GPU ID bounds works in general.

I'm *extremely* dubious about this getting hooked up to the loop unroller, of all things.

If what you're trying to do is to remove loops that're guaranteed to run exactly once, I'd start by trying to upstream the code in, say, https://github.com/iree-org/iree/blob/26a89c30329b18efd5ac29aff258402b481ea9e4/compiler/src/iree/compiler/Codegen/Transforms/RemoveSingleIterationLoop.cpp - which is a pass that uses the affine value bounds analysis to do exactly this

Especially since `gpu.launch` now implemnets `ValueBoundsOpInterface`

https://github.com/llvm/llvm-project/pull/128113