[Mlir-commits] [mlir] [mlir][emitc][NFC] Add type clarification to the description for the emitc.global op (PR #127997)

Marius Brehler llvmlistbot at llvm.org
Fri Feb 21 06:49:01 PST 2025


================
@@ -1147,6 +1147,8 @@ def EmitC_GlobalOp : EmitC_Op<"global", [Symbol]> {
     emitc.global @x : !emitc.array<2xf32> = dense<0.0>
     // Global variable with an initial values.
     emitc.global @x : !emitc.array<3xi32> = dense<[0, 1, 2]>
+    // Global variable with an opaque initial value.
+    emitc.global @y : !emitc.opaque<"char"> = #emitc.opaque<"CHAR_MIN">
----------------
marbre wrote:

```suggestion
    emitc.global @x : !emitc.opaque<"char"> = #emitc.opaque<"CHAR_MIN">
```

Seems in the sample, for simplicity all globals are named `@x`.

https://github.com/llvm/llvm-project/pull/127997


More information about the Mlir-commits mailing list