[Mlir-commits] [mlir] [mlir][mpi] Lowering Mpi To LLVM (PR #127053)

Christian Ulmann llvmlistbot at llvm.org
Fri Feb 21 00:29:45 PST 2025


https://github.com/Dinistro commented:

Very nice, thanks for changing this to use the DLTI. 
Considering the new structure, it might be more elegant to rely on virtual dispatch to implement the different lowering strategies. This use case very nicely fits the strategy pattern, I believe.
This would ensure that you only need to check the DLTI once and can thereafter rely on the virtual dispatch to delegate to the proper implementation.

https://github.com/llvm/llvm-project/pull/127053


More information about the Mlir-commits mailing list