[Mlir-commits] [mlir] [mlir] Allow trailing digit for alias in AsmPrinter (PR #127993)
Hongren Zheng
llvmlistbot at llvm.org
Thu Feb 20 10:13:55 PST 2025
ZenithalHourlyRate wrote:
> I'm having trouble finding which of the tests covers the situation where a user defined alias conflicts with autogenerated ones, can you point me to which test is covering this case?
OK I realized for the following case it will conflict
```mlir
!test.type<a = 3> // suggest !name0
!test.type<a = 4> // suggest !name0
!test.another<b = 3> // suggest !name0_
!test.another<b = 4> // suggest !name0_1
```
The result now would be
```
!name0
!name0_1
!name0_2
!name0_1
```
I think such detection could be made by tarvering `nameCount`, but that will bring some overhead. Will attach a possible fix below.
https://github.com/llvm/llvm-project/pull/127993
More information about the Mlir-commits
mailing list