[Mlir-commits] [mlir] c2e5142 - [MLIR][LLVM] Fold extract of constant (#127927)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Thu Feb 20 08:00:46 PST 2025
Author: William Moses
Date: 2025-02-20T10:00:42-06:00
New Revision: c2e51428bf86def5094a3f14029f75f3ac0e477e
URL: https://github.com/llvm/llvm-project/commit/c2e51428bf86def5094a3f14029f75f3ac0e477e
DIFF: https://github.com/llvm/llvm-project/commit/c2e51428bf86def5094a3f14029f75f3ac0e477e.diff
LOG: [MLIR][LLVM] Fold extract of constant (#127927)
Co-authored-by: Christian Ulmann <christianulmann at gmail.com>
Added:
Modified:
mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
mlir/test/Dialect/LLVMIR/canonicalize.mlir
Removed:
################################################################################
diff --git a/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp b/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
index bfcba40555a7c..ccf8f72b2b230 100644
--- a/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
+++ b/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
@@ -1932,6 +1932,18 @@ OpFoldResult LLVM::ExtractValueOp::fold(FoldAdaptor adaptor) {
getContainerMutable().set(extractValueOp.getContainer());
return getResult();
}
+
+ {
+ DenseElementsAttr constval;
+ matchPattern(getContainer(), m_Constant(&constval));
+ if (constval && constval.getElementType() == getType()) {
+ if (isa<SplatElementsAttr>(constval))
+ return constval.getSplatValue<Attribute>();
+ if (getPosition().size() == 1)
+ return constval.getValues<Attribute>()[getPosition()[0]];
+ }
+ }
+
auto insertValueOp = getContainer().getDefiningOp<InsertValueOp>();
OpFoldResult result = {};
while (insertValueOp) {
diff --git a/mlir/test/Dialect/LLVMIR/canonicalize.mlir b/mlir/test/Dialect/LLVMIR/canonicalize.mlir
index c509cd82227c2..a793caca064ec 100644
--- a/mlir/test/Dialect/LLVMIR/canonicalize.mlir
+++ b/mlir/test/Dialect/LLVMIR/canonicalize.mlir
@@ -96,6 +96,28 @@ llvm.func @fold_extract_extractvalue(%arr: !llvm.struct<(i64, array<1 x ptr<1>>)
// -----
+// CHECK-LABEL: fold_extract_const
+// CHECK-NOT: extractvalue
+// CHECK: llvm.mlir.constant(5.000000e-01 : f64)
+llvm.func @fold_extract_const() -> f64 {
+ %a = llvm.mlir.constant(dense<[-8.900000e+01, 5.000000e-01]> : tensor<2xf64>) : !llvm.array<2 x f64>
+ %b = llvm.extractvalue %a[1] : !llvm.array<2 x f64>
+ llvm.return %b : f64
+}
+
+// -----
+
+// CHECK-LABEL: fold_extract_splat
+// CHECK-NOT: extractvalue
+// CHECK: llvm.mlir.constant(-8.900000e+01 : f64)
+llvm.func @fold_extract_splat() -> f64 {
+ %a = llvm.mlir.constant(dense<-8.900000e+01> : tensor<2xf64>) : !llvm.array<2 x f64>
+ %b = llvm.extractvalue %a[1] : !llvm.array<2 x f64>
+ llvm.return %b : f64
+}
+
+// -----
+
// CHECK-LABEL: fold_bitcast
// CHECK-SAME: %[[ARG:[[:alnum:]]+]]
// CHECK-NEXT: llvm.return %[[ARG]]
More information about the Mlir-commits
mailing list