[Mlir-commits] [mlir] [Mlir] decompose generic by unfolding projected permutation crash fix (PR #122449)

[Andrzej Warzyński]

banach-space wrote:

> The proposal sounds reasonable. In the end, it's matter of consistency and convention given the usage is widespread enough. I'm a bit skeptical whether there's really an efficient way to communicate and/or steer such design choices. That being said, it doesn't hurt to try with a recommendation and a PSA. A concrete passage always helps in spreading the word around.

https://discourse.llvm.org/t/rfc-should-we-aim-for-more-consistency-in-tests/

Note, that's proposing new guidelines for writing tests (i.e. it's more general). Within that, I use `@negative_CASE`. **That's just the first step** - if folks approve, we will iterate (I mostly care about consistency than the actual style that we use).

**Why did I propose a bigger change?** I felt that in order to discuss/propose multiple variants for "failing tests", we first ought to extend the docs (currently there's no good place for these things). Hence my PR + RFC. Also, hopefully that RFC will help us understand the sentiments within the community.

In any case, lets move the discussion to Discourse. Thanks Adam!

https://github.com/llvm/llvm-project/pull/122449