[Mlir-commits] [mlir] [mlir][tosa] Add FP8 support (PR #127730)

[Georgios Pinitas]

================
@@ -217,15 +217,17 @@ void mlir::tosa::printTypeOrAttr(OpAsmPrinter &p, Operation *op, TypeAttr type,
 
 template <typename T>
 static LogicalResult verifyConvOp(T op) {
-  // All TOSA conv ops have an input and weight arguments which must be ranked
-  // tensors.
+  // All TOSA conv ops have an input() and weight().
   auto inputType = llvm::dyn_cast<RankedTensorType>(op.getInput().getType());
+
+  RankedTensorType weightType;
+  weightType = llvm::dyn_cast<RankedTensorType>(op.getWeight().getType());
----------------
GeorgeARM wrote:

Why move it up and not declare it before use?

https://github.com/llvm/llvm-project/pull/127730