[Mlir-commits] [mlir] [MLIR][NFC] Use base alias for constructor inheritance (PR #127756)

[lorenzo chelini]

https://github.com/chelini created https://github.com/llvm/llvm-project/pull/127756

During my previous cleanup (#127403), I did not notice that we defined a type alias for the base class. This type alias allows us to use the shorter form Base::Base, and this PR switches to that.

>From 8cdc8ac99e66ebb0a9bf3cd93f368c5e2a544d1f Mon Sep 17 00:00:00 2001
From: lorenzo chelini <lchelini at nvidia.com>
Date: Wed, 19 Feb 2025 07:40:06 +0100
Subject: [PATCH] [MLIR][NFC] Use base alias for constructor inheritance

During my previous cleanup (#127403), I did not notice that we defined a type
alias for the base class. This type alias allows us to use the shorter form
Base::Base, and this PR switches to that.
---
 mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp             | 2 +-
 mlir/lib/Conversion/ArithToSPIRV/ArithToSPIRV.cpp               | 2 +-
 mlir/lib/Conversion/ComplexToStandard/ComplexToStandard.cpp     | 2 +-
 .../Conversion/ControlFlowToSPIRV/ControlFlowToSPIRVPass.cpp    | 2 +-
 mlir/lib/Conversion/FuncToSPIRV/FuncToSPIRVPass.cpp             | 2 +-
 mlir/lib/Conversion/MemRefToSPIRV/MemRefToSPIRVPass.cpp         | 2 +-
 mlir/lib/Conversion/SCFToGPU/SCFToGPUPass.cpp                   | 2 +-
 mlir/lib/Conversion/TensorToSPIRV/TensorToSPIRVPass.cpp         | 2 +-
 mlir/lib/Conversion/TosaToArith/TosaToArithPass.cpp             | 2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp b/mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp
index c62314e504dcc..158268695d4a4 100644
--- a/mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp
+++ b/mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp
@@ -1038,7 +1038,7 @@ struct AMDGPUDPPLowering : public ConvertOpToLLVMPattern<DPPOp> {
 
 struct ConvertAMDGPUToROCDLPass
     : public impl::ConvertAMDGPUToROCDLPassBase<ConvertAMDGPUToROCDLPass> {
-  using ConvertAMDGPUToROCDLPassBase::ConvertAMDGPUToROCDLPassBase;
+  using Base::Base;
 
   void runOnOperation() override {
     MLIRContext *ctx = &getContext();
diff --git a/mlir/lib/Conversion/ArithToSPIRV/ArithToSPIRV.cpp b/mlir/lib/Conversion/ArithToSPIRV/ArithToSPIRV.cpp
index 5887e37b7f0b4..1f2781aa82114 100644
--- a/mlir/lib/Conversion/ArithToSPIRV/ArithToSPIRV.cpp
+++ b/mlir/lib/Conversion/ArithToSPIRV/ArithToSPIRV.cpp
@@ -1338,7 +1338,7 @@ void mlir::arith::populateArithToSPIRVPatterns(
 namespace {
 struct ConvertArithToSPIRVPass
     : public impl::ConvertArithToSPIRVPassBase<ConvertArithToSPIRVPass> {
-  using ConvertArithToSPIRVPassBase::ConvertArithToSPIRVPassBase;
+  using Base::Base;
 
   void runOnOperation() override {
     Operation *op = getOperation();
diff --git a/mlir/lib/Conversion/ComplexToStandard/ComplexToStandard.cpp b/mlir/lib/Conversion/ComplexToStandard/ComplexToStandard.cpp
index ea25d5afaeeca..5089179435f1e 100644
--- a/mlir/lib/Conversion/ComplexToStandard/ComplexToStandard.cpp
+++ b/mlir/lib/Conversion/ComplexToStandard/ComplexToStandard.cpp
@@ -1072,7 +1072,7 @@ namespace {
 struct ConvertComplexToStandardPass
     : public impl::ConvertComplexToStandardPassBase<
           ConvertComplexToStandardPass> {
-  using ConvertComplexToStandardPassBase::ConvertComplexToStandardPassBase;
+  using Base::Base;
 
   void runOnOperation() override;
 };
diff --git a/mlir/lib/Conversion/ControlFlowToSPIRV/ControlFlowToSPIRVPass.cpp b/mlir/lib/Conversion/ControlFlowToSPIRV/ControlFlowToSPIRVPass.cpp
index a0ae39a353a95..03f4bf4df4912 100644
--- a/mlir/lib/Conversion/ControlFlowToSPIRV/ControlFlowToSPIRVPass.cpp
+++ b/mlir/lib/Conversion/ControlFlowToSPIRV/ControlFlowToSPIRVPass.cpp
@@ -28,7 +28,7 @@ namespace {
 class ConvertControlFlowToSPIRVPass final
     : public impl::ConvertControlFlowToSPIRVPassBase<
           ConvertControlFlowToSPIRVPass> {
-  using ConvertControlFlowToSPIRVPassBase::ConvertControlFlowToSPIRVPassBase;
+  using Base::Base;
   void runOnOperation() override;
 };
 } // namespace
diff --git a/mlir/lib/Conversion/FuncToSPIRV/FuncToSPIRVPass.cpp b/mlir/lib/Conversion/FuncToSPIRV/FuncToSPIRVPass.cpp
index 572a432d6d641..8ed9f659afb10 100644
--- a/mlir/lib/Conversion/FuncToSPIRV/FuncToSPIRVPass.cpp
+++ b/mlir/lib/Conversion/FuncToSPIRV/FuncToSPIRVPass.cpp
@@ -27,7 +27,7 @@ namespace {
 /// A pass converting MLIR Func operations into the SPIR-V dialect.
 class ConvertFuncToSPIRVPass
     : public impl::ConvertFuncToSPIRVPassBase<ConvertFuncToSPIRVPass> {
-  using ConvertFuncToSPIRVPassBase::ConvertFuncToSPIRVPassBase;
+  using Base::Base;
   void runOnOperation() override;
 };
 } // namespace
diff --git a/mlir/lib/Conversion/MemRefToSPIRV/MemRefToSPIRVPass.cpp b/mlir/lib/Conversion/MemRefToSPIRV/MemRefToSPIRVPass.cpp
index 5d53aef199d52..b06ab44d159af 100644
--- a/mlir/lib/Conversion/MemRefToSPIRV/MemRefToSPIRVPass.cpp
+++ b/mlir/lib/Conversion/MemRefToSPIRV/MemRefToSPIRVPass.cpp
@@ -27,7 +27,7 @@ namespace {
 /// A pass converting MLIR MemRef operations into the SPIR-V dialect.
 class ConvertMemRefToSPIRVPass
     : public impl::ConvertMemRefToSPIRVPassBase<ConvertMemRefToSPIRVPass> {
-  using ConvertMemRefToSPIRVPassBase::ConvertMemRefToSPIRVPassBase;
+  using Base::Base;
   void runOnOperation() override;
 };
 } // namespace
diff --git a/mlir/lib/Conversion/SCFToGPU/SCFToGPUPass.cpp b/mlir/lib/Conversion/SCFToGPU/SCFToGPUPass.cpp
index 8e2efbc7f4280..99631705851fd 100644
--- a/mlir/lib/Conversion/SCFToGPU/SCFToGPUPass.cpp
+++ b/mlir/lib/Conversion/SCFToGPU/SCFToGPUPass.cpp
@@ -34,7 +34,7 @@ namespace {
 // walk the function recursively to avoid considering nested loops.
 struct ForLoopMapper
     : public impl::ConvertAffineForToGPUPassBase<ForLoopMapper> {
-  using ConvertAffineForToGPUPassBase::ConvertAffineForToGPUPassBase;
+  using Base::Base;
 
   void runOnOperation() override {
     for (Operation &op : llvm::make_early_inc_range(
diff --git a/mlir/lib/Conversion/TensorToSPIRV/TensorToSPIRVPass.cpp b/mlir/lib/Conversion/TensorToSPIRV/TensorToSPIRVPass.cpp
index 9e98dc7d7aaf6..f07386ea80124 100644
--- a/mlir/lib/Conversion/TensorToSPIRV/TensorToSPIRVPass.cpp
+++ b/mlir/lib/Conversion/TensorToSPIRV/TensorToSPIRVPass.cpp
@@ -29,7 +29,7 @@ namespace {
 /// A pass converting MLIR Tensor operations into the SPIR-V dialect.
 class ConvertTensorToSPIRVPass
     : public impl::ConvertTensorToSPIRVPassBase<ConvertTensorToSPIRVPass> {
-  using ConvertTensorToSPIRVPassBase::ConvertTensorToSPIRVPassBase;
+  using Base::Base;
 
   void runOnOperation() override {
     MLIRContext *context = &getContext();
diff --git a/mlir/lib/Conversion/TosaToArith/TosaToArithPass.cpp b/mlir/lib/Conversion/TosaToArith/TosaToArithPass.cpp
index 15ddd3f5c16f1..ede3c9e0040fd 100644
--- a/mlir/lib/Conversion/TosaToArith/TosaToArithPass.cpp
+++ b/mlir/lib/Conversion/TosaToArith/TosaToArithPass.cpp
@@ -30,7 +30,7 @@ using namespace tosa;
 
 namespace {
 struct TosaToArith : public impl::TosaToArithPassBase<TosaToArith> {
-  using TosaToArithPassBase::TosaToArithPassBase;
+  using Base::Base;
 
   void runOnOperation() override {
     RewritePatternSet patterns(&getContext());