[Mlir-commits] [llvm] [mlir] [mlir][tensor][linalg] Move RelayoutOpInterface from linalg back to tensor (PR #127533)

[Renato Golin]

rengolin wrote:

> > > I'm aware that bazel builds are not officially supported
> > > please do not propose radical code changes to fix the Bazel build.
> 
> And I asked whether it might also not be ideal for cmake, but I'm not familiar with that build.

Perhaps starting with a question instead of a revert PR would have been better. PRs have the tendency to being missed by some, approved by others, and by the time you realize your patch has been reverted, many things have changed and you have to start from scratch.

> > Up until now, the tensor dialect had a direct dependency with linalg,
> 
> That is, the Linalg dialect depends on various things from Tensor, including several [op definitions](https://github.com/llvm/llvm-project/blob/3fa85c7cce3047ae0fc54874c2bf8340e8c4803c/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp#L68). #123902 introduced a dependency the other way around, where the tensor ops depend on linalg.

No, I mean, the lowering of the previous `tensor.pack` operation involved using `linalg.fill`, which was the main reason we moved the ops across. I'm surprised this wasn't a dependency for Bazel until now.

https://github.com/llvm/llvm-project/pull/127533