[Mlir-commits] [llvm] [mlir] [mlir][tensor][linalg] Move RelayoutOpInterface from linalg back to tensor (PR #127533)
Christian Sigg
llvmlistbot at llvm.org
Mon Feb 17 11:33:49 PST 2025
chsigg wrote:
Thanks for your feedback. I'm trying to fix the [bazel build](https://buildkite.com/llvm-project/upstream-bazel/builds/125819). However, I cannot add `LinalgDialect` as a dependency of `TensorDialect`, because it would create a circle (`LinalgDialect` already depends on `TensorDialect`).
A potential alternative route would be to expose the RelayoutOpInterface in a separate header (so that it can become its own self-contained target). I'm aware that bazel builds are not officially supported and if need be we can come up with creative ways to write BUILD files to handle the current code. We would have targets that expose Linalg.h but only implement a subset of what the header declares. We have done this before, but it's a can of worms and we made an effort to fix these a while back (see e.g. https://github.com/llvm/llvm-project/pull/86637).
I'm not familiar with the (cmake) build, so I can't tell if the current form has downsides there as well. Like, do users of the tensor dialect now need to build all of linalg, but didn't need to before? And if it were the case, is it an issue?
https://github.com/llvm/llvm-project/pull/127533
More information about the Mlir-commits
mailing list